Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin, Alexander Couzens.
6 comments:
File src/mainboard/apple/macbookpro8_1/Kconfig:
config VGA_BIOS_FILE
string
default "pci8086,0126.rom"
config VGA_BIOS_ID
string
default "8086,0126"
Needs to be extracted from vendor firmware
Let's just drop it.
File src/mainboard/apple/macbookpro8_1/Kconfig:
Patch Set #16, Line 38: default 28
Um, gpio.c configures this as an input.
Yes, I'm confused here, can you look at schematics please?
File src/mainboard/apple/macbookpro8_1/acpi/superio.asl:
Patch Set #22, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
As per commit cf4722d317 (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) empty files sh […]
Thanks
File src/mainboard/apple/macbookpro8_1/acpi_tables.c:
gnvs->tcrt = 100;
gnvs->tpsv = 90;
I don't think these are needed.
Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
Patch Set #16, Line 52: register "pcie_port_coalesce" = "1"
Doesn't seem to be needed
Done
File src/mainboard/apple/macbookpro8_1/mainboard.c:
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
GMA_INT15_PANEL_FIT_DEFAULT,
GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
This particular wasn't, but I tested VGA BIOS on MBP 10,1 and MBA 5,2.
Let's just drop it.
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.