Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80159?usp=email )
Change subject: mb/google/rex/var/screebo: Modify TCC_offset to 20 ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Is this reviewed by Screebo ODM? Please check bug b:309569030#comment4 for TCC_offset change discussion. It seems ODM not considering to change this TCC_Offset right now.
w/o ur override the tcc_offset was 20. now you have force set the tcc_offset to 10 hence, this CL is required to restore the current settings
I hope you have noticed below comments bt still you have changed the screebo device thermal behaviour w/ ur cl.
``` Hi Sumeet 1.For user experience view, we don't want CPU temperature be close to much higher temperature as 100 degree C. 2.The performance target is aligned on quadrilateral meeting. 3.Now, SW setting modification will impact the system validation plan due to FW locked down. So we don't suggest to implement this modification as you pointed at this moment. ```