Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun.
View Change
1 comment:
Patchset:
Patch Set #1:
Is this reviewed by Screebo ODM?
Please check bug b:309569030#comment4 for TCC_offset change discussion. It seems ODM not considering to change this TCC_Offset right now.
w/o ur override the tcc_offset was 20. now you have force set the tcc_offset to 10 hence, this CL is required to restore the current settings
I hope you have noticed below comments bt still you have changed the screebo device thermal behaviour w/ ur cl.
```
Hi Sumeet
1.For user experience view, we don't want CPU temperature be close to much
higher temperature as 100 degree C.
2.The performance target is aligned on quadrilateral meeting.
3.Now, SW setting modification will impact the system validation plan due
to FW locked down. So we don't suggest to implement this modification as
you pointed at this moment.
```
To view, visit change 80159. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc76f9c0054f21f066b779e6404a1c175eb396a0
Gerrit-Change-Number: 80159
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Jakub Czapiga <czapiga@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Comment-Date: Wed, 24 Jan 2024 13:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-MessageType: comment