Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Michal Motyl, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter
......................................................................
Patch Set 6:
(6 comments)
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/62855751_55851ef3
PS6, Line 2097: #define PCI_VID_AKS 0x416c
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/e6a62c65_e88e742a
PS6, Line 2098: #define PCI_DID_AKS_ALADDINCARD 0x0100
'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/038fa37f_14ba6434
PS6, Line 2099: #define PCI_DID_AKS_CPC 0x0200
'AKS' may be misspelled - perhaps 'ASK'?
File src/soc/intel/skylake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/3f661bb7_894250ac
PS6, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) {
code indent should use tabs where possible
File src/southbridge/amd/agesa/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/7c03a752_e3ce595b
PS6, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
File src/southbridge/amd/pi/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):
https://review.coreboot.org/c/coreboot/+/39331/comment/36210b01_249cd018
PS6, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {
else should follow close brace '}'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Gerrit-Change-Number: 39331
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
d.guckian20@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 20 Nov 2021 05:01:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment