Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Michal Motyl, Tim Chu.

View Change

6 comments:

• File src/include/device/pci_ids.h:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 2097: #define PCI_VID_AKS 0x416c

    'AKS' may be misspelled - perhaps 'ASK'?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 2098: #define PCI_DID_AKS_ALADDINCARD 0x0100

    'AKS' may be misspelled - perhaps 'ASK'?

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 2099: #define PCI_DID_AKS_CPC 0x0200

    'AKS' may be misspelled - perhaps 'ASK'?

• File src/soc/intel/skylake/vr_config.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) {

    code indent should use tabs where possible

• File src/southbridge/amd/agesa/hudson/hudson.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {

    else should follow close brace '}'

• File src/southbridge/amd/pi/hudson/hudson.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133895):

    Patch Set #6, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) {

    else should follow close brace '}'

To view, visit change 39331. To unsubscribe, or for help writing mail filters, visit settings.