Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31080 )
Change subject: vendorcode/google/chromeos: Use ACPI GPIO pin when possible ......................................................................
Patch Set 2:
Patch Set 1:
(2 comments)
Patch Set 1:
I do understand the requirement to report the mapped pin number. What I don't understand is, when would we ever need to have the raw number? i.e. why can't we make the mapped numbers the default?
That was my original plan, use this if CONFIG_GENERIC_GPIO_LIB was defined but that ended up breaking a bunch of random boards that don't have a full GPIO implementation.
I realized I had not really considered the easy fix for my previous patch that was reverted. This seems easier and removes the kconfig option.