Patch Set 1:

(2 comments)

Patch Set 1:

I do understand the requirement to report the mapped
pin number. What I don't understand is, when would we
ever need to have the raw number? i.e. why can't we
make the mapped numbers the default?

That was my original plan, use this if CONFIG_GENERIC_GPIO_LIB was defined but that ended up breaking a bunch of random boards that don't have a full GPIO implementation.

I realized I had not really considered the easy fix for my previous patch that was reverted. This seems easier and removes the kconfig option.

View Change

To view, visit change 31080. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ad5099b7f2f871c7e516988f60a54eb2a75bef7
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Fri, 25 Jan 2019 19:11:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment