[coreboot-gerrit] Change in coreboot[master]: lib/spd: respect spd memory part name override if present

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )

Change subject: lib/spd: respect spd memory part name override if present
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45459/16/src/lib/spd_bin.c 
File src/lib/spd_bin.c:

https://review.coreboot.org/c/coreboot/+/45459/16/src/lib/spd_bin.c@202 
PS16, Line 202: spd_get_name(spd, spd_name, ARRAY_SIZE(spd_name), type);
              : 
              : 	printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
> Does this mean (this change will mean) that all mainboards going forward on chromeos will define their memory part number in the CBI?  Is that a mandate for all chromebooks?

Yes, all boards using memory down configuration will have their part number in CBI(at least for Intel and AMD-based platforms). This is already true for hatch, octopus, dedede, volteer and zork. Same will continue for future platforms.

Also, having a Kconfig that allows mainboard to select whether it wants the part number to be read from CBI will ensure that this strong implementation is enabled only on the boards that really need it.