View Change
1 comment:
File src/lib/spd_bin.c:
Patch Set #16, Line 202:
spd_get_name(spd, spd_name, ARRAY_SIZE(spd_name), type);
printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
Does this mean (this change will mean) that all mainboards going forward on chromeos will define their memory part number in the CBI? Is that a mandate for all chromebooks?
Yes, all boards using memory down configuration will have their part number in CBI(at least for Intel and AMD-based platforms). This is already true for hatch, octopus, dedede, volteer and zork. Same will continue for future platforms.
Also, having a Kconfig that allows mainboard to select whether it wants the part number to be read from CBI will ensure that this strong implementation is enabled only on the boards that really need it.
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0
Gerrit-Change-Number: 45459
Gerrit-PatchSet: 16
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Mon, 21 Sep 2020 20:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro@google.com>
Gerrit-MessageType: comment