build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40334 )
Change subject: configs/builder/config.ocp.sonorapass: Config for SonoraPass PO. src/mainboard/ocp/sonorapass/*.*: Preliminiary platform porting for SonoraPass PO. ......................................................................
Patch Set 1:
(72 comments)
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... File src/mainboard/ocp/sonorapass/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 23: struct config_data port80[] = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 24: /* {Type, base, reg, and, or} */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 24: /* {Type, base, reg, and, or} */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 24: /* {Type, base, reg, and, or} */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 25: /* Set command source of GPIOH to LPC */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 26: {MEM, ASPEED_GPIO_BASE, 0x68, 0xFEFFFFFF, 0x01000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 26: {MEM, ASPEED_GPIO_BASE, 0x68, 0xFEFFFFFF, 0x01000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 27: {MEM, ASPEED_GPIO_BASE, 0x6C, 0xFEFFFFFF, 0x00000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 27: {MEM, ASPEED_GPIO_BASE, 0x6C, 0xFEFFFFFF, 0x00000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 28: /* Unlock SCU Registers */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 29: {MEM, ASPEED_SCU_BASE, 0x00, 0x00000000, 0x1688A8A8}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 29: {MEM, ASPEED_SCU_BASE, 0x00, 0x00000000, 0x1688A8A8}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 30: /* Program GPIOH multi-function to GPIO */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 31: {MEM, ASPEED_SCU_BASE, 0x90, 0xFFFFFF3F, 0x00000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 31: {MEM, ASPEED_SCU_BASE, 0x90, 0xFFFFFF3F, 0x00000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 32: /* Program GPIOH as output */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 33: {MEM, ASPEED_GPIO_BASE, 0x24, 0x00FFFFFF, 0xFF000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 33: {MEM, ASPEED_GPIO_BASE, 0x24, 0x00FFFFFF, 0xFF000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 34: /* Set snooping address#0 as 80h */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 35: {MEM, ASPEED_LPC_BASE, 0x90, 0xFFFF0000, 0x00000080}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 35: {MEM, ASPEED_LPC_BASE, 0x90, 0xFFFF0000, 0x00000080}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 36: /* Enable snooping address#0 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 37: {MEM, ASPEED_LPC_BASE, 0x80, 0xFFFFFFFE, 0x00000001}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 37: {MEM, ASPEED_LPC_BASE, 0x80, 0xFFFFFFFE, 0x00000001}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 38: /* Enable GPIO device */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 39: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_ENTRY_KEY}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 39: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_ENTRY_KEY}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 40: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_ENTRY_KEY}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 40: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_ENTRY_KEY}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 41: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, LDN_SEL}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 41: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, LDN_SEL}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 42: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, AST2400_GPIO}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 42: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, AST2400_GPIO}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 43: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ACT_REG}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 43: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ACT_REG}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 44: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, PORT80_GPIO_EN | ACTIVATE_VALUE}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 44: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, PORT80_GPIO_EN | ACTIVATE_VALUE}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 45: /* Select GPIOH for port80 GPIO */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 46: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, PORT80_GPIO_SEL}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 46: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, PORT80_GPIO_SEL}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 47: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, GPIOH_SEL}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 47: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, GPIOH_SEL}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 48: /* Disable GPIO Device */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 49: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, LDN_SEL}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 49: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, LDN_SEL}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 50: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, AST2400_GPIO}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 50: {SIO, 0, ASPEED_CONFIG_DATA, 0x00, AST2400_GPIO}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 51: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ACT_REG}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 51: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ACT_REG}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 52: {SIO, 0, ASPEED_CONFIG_DATA, 0xFE, DEACTIVATE_VALUE}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 52: {SIO, 0, ASPEED_CONFIG_DATA, 0xFE, DEACTIVATE_VALUE}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 53: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_EXIT_KEY} code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 53: {SIO, 0, ASPEED_CONFIG_INDEX, 0x00, ASPEED_EXIT_KEY} please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 55: struct config_data uart[] = { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 56: /* {Type, base, reg, and, or} */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 56: /* {Type, base, reg, and, or} */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 56: /* {Type, base, reg, and, or} */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 57: /* Unlock SCU Registers */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 58: {MEM, ASPEED_SCU_BASE, 0x00, 0x00000000, 0x1688A8A8}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 58: {MEM, ASPEED_SCU_BASE, 0x00, 0x00000000, 0x1688A8A8}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 59: /* SERIAL PORT1 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 60: {MEM, ASPEED_SCU_BASE, 0x84, 0xFF00FFFF, 0x00C00000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 60: {MEM, ASPEED_SCU_BASE, 0x84, 0xFF00FFFF, 0x00C00000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 61: {MEM, ASPEED_GPIO_BASE, 0x90, 0xFFFFFFCF, 0x00000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 61: {MEM, ASPEED_GPIO_BASE, 0x90, 0xFFFFFFCF, 0x00000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 62: /* SERIAL PORT2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 63: {MEM, ASPEED_SCU_BASE, 0x84, 0x00FFFFFF, 0xC0000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 63: {MEM, ASPEED_SCU_BASE, 0x84, 0x00FFFFFF, 0xC0000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 64: {MEM, ASPEED_GPIO_BASE, 0x90, 0xFFFFFFCF, 0x00000000}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 64: {MEM, ASPEED_GPIO_BASE, 0x90, 0xFFFFFFCF, 0x00000000}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 78: aspeed_early_config(ASPEED_CONFIG_INDEX, port80, ARRAY_SIZE(port80)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40334/1/src/mainboard/ocp/sonorapas... PS1, Line 81: aspeed_early_config(ASPEED_CONFIG_INDEX, uart, ARRAY_SIZE(uart)); please, no spaces at the start of a line