[coreboot-gerrit] Change in coreboot[master]: [RFC] Introduce vpd_get_option()

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45774 )

Change subject: [RFC] Introduce vpd_get_option()
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45774/3/src/Kconfig 
File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/45774/3/src/Kconfig@146 
PS3, Line 146: 	  option to be queried needs to be added manually to vpd_get_option().
> I completely agree. But people asked to use VPD for it... I'm not sure if […]

We need a way to enable image behavior customization at boot time. VPD may not seem to be ideal, but it is still more feature rich than other coreboot options. Unless other coreboot options reaches feature parity with VPD, VPD is still the best choice.
Re-reading VPD from flash in every stage is okay for OCP servers.
If there is FMAP or flash access problem, we would fall back to use default values.