View Change
1 comment:
File src/Kconfig:
Patch Set #3, Line 146: option to be queried needs to be added manually to vpd_get_option().
I completely agree. But people asked to use VPD for it... I'm not sure if […]
We need a way to enable image behavior customization at boot time. VPD may not seem to be ideal, but it is still more feature rich than other coreboot options. Unless other coreboot options reaches feature parity with VPD, VPD is still the best choice.
Re-reading VPD from flash in every stage is okay for OCP servers.
If there is FMAP or flash access problem, we would fall back to use default values.
To view, visit change 45774. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I825388f767d1d87f44923eff5ae6680105fa801e
Gerrit-Change-Number: 45774
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Marc Jones <marc.jones@amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: insomniac <insomniac@slackware.it>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 09 Oct 2020 00:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment