Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39039 )
Change subject: mainboard/google/dedede: Migrate onto get fw_config helper ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39039/11/src/mainboard/google/deded... File src/mainboard/google/dedede/board_info.c:
https://review.coreboot.org/c/coreboot/+/39039/11/src/mainboard/google/deded... PS11, Line 53: return -1; Not quite clear why the check is removed. There is a good possibility that FW_CONFIG might not be provisioned during the early stages of the program and there is no way to differentiate the provisioned and non-provisioned scenario without checking the SKU.