Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39039 ) Change subject: mainboard/google/dedede: Migrate onto get fw_config helper ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/c/coreboot/+/39039/11/src/mainboard/google/deded... File src/mainboard/google/dedede/board_info.c: https://review.coreboot.org/c/coreboot/+/39039/11/src/mainboard/google/deded... PS11, Line 53: return -1; Not quite clear why the check is removed. There is a good possibility that FW_CONFIG might not be provisioned during the early stages of the program and there is no way to differentiate the provisioned and non-provisioned scenario without checking the SKU. -- To view, visit https://review.coreboot.org/c/coreboot/+/39039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic84ffb6188d1f98b076142829fe49afd38c528bc Gerrit-Change-Number: 39039 Gerrit-PatchSet: 11 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 28 Feb 2020 17:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment