Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 124:
(2 comments)
The remaining capacity of the battery stopped updating, so I reverted a few things. Need to double-check what precisely fixed it.
https://review.coreboot.org/c/coreboot/+/35523/122/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl:
https://review.coreboot.org/c/coreboot/+/35523/122/src/mainboard/acer/aspire... PS122, Line 11: Name (ACST, One)
battery.asl, but I'll switch it to use the variable directly from the EC instead.
Reverted. Need to confirm.
https://review.coreboot.org/c/coreboot/+/35523/122/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/35523/122/src/mainboard/acer/aspire... PS122, Line 78: (Local0 ^ One)
EBCM is 1 bit. Good catch, thanks.
Reverted. Need to confirm impact.