11 Sep
2019
11 Sep
'19
9:03 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35289 )
Change subject: [WIP] intel/fsp2_0: Restrict references to CAR ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35289/2/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/35289/2/src/drivers/intel/fsp2_0/me... PS2, Line 402: if (!(CONFIG(FSP_M_XIP) && CONFIG(FSP_USES_CB_STACK))) {
!CONFIG(FSP_USES_CB_STACK) ?
Why is FSP_USES_CB_STACK added at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35289
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1e33d67722db086d9f9feff0e1d289f40d4ef5
Gerrit-Change-Number: 35289
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Vincent Zimmer vincent.zimmer@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 07:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment