[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu2: use AGESA 1.0.0.4 with adjusted AGESA header

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35906 )

Change subject: mb/pcengines/apu2: use AGESA 1.0.0.4 with adjusted AGESA header
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 2:
> >
> > IMHO, the header files belong where the blob lives (blobs
> > repo). This makes it much easier to keep them synchronized!
> >
> > In this case, we should also revive the 1.0.0.4 binary on
> > blobs' master branch. If we have per-version dirs there,
> > we'd also have a place for the proper header files, without
> > fragile preprocessor guards.
>
> The 1.0.0.4 is present in mainboard/pcengines/apu2. The idea with having the headers in blobs repo like FSP is also good. I just didn't suggest that to Piotr since I have no idea about the rules of committing to blobs repo.

The license of the header permits to do that (redistribution), so go ahead!