Patch Set 3:

Patch Set 2:

IMHO, the header files belong where the blob lives (blobs
repo). This makes it much easier to keep them synchronized!

In this case, we should also revive the 1.0.0.4 binary on
blobs' master branch. If we have per-version dirs there,
we'd also have a place for the proper header files, without
fragile preprocessor guards.

The 1.0.0.4 is present in mainboard/pcengines/apu2. The idea with having the headers in blobs repo like FSP is also good. I just didn't suggest that to Piotr since I have no idea about the rules of committing to blobs repo.

The license of the header permits to do that (redistribution), so go ahead!

View Change

To view, visit change 35906. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d85ee14e35dae8079e8d552b6530a3867f65876
Gerrit-Change-Number: 35906
Gerrit-PatchSet: 3
Gerrit-Owner: Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 10 Oct 2019 11:00:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment