Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )
Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................
Patch Set 4:
(4 comments)
Does some documentation need to be updated?
https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@7 PS4, Line 7: mainboard mb
https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@12 PS4, Line 12: Removed hybrid graphics options too. Why?
https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@9 PS4, Line 9: Enable the dGPU on the Lenovo T440P. It uses the same code : (roughly) of the T430S. By default, it is set to be : disabled however it can be enabled via the nvram option : enable_dual_graphics. Removed hybrid graphics options too. : Tested on a T440P with Ubuntu 18.04.3 (successful). Tested : on same machine with Windows 10 1909 (blue screen at boot). Please reflow for 75 characters.
https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/romstage.c:
https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... PS4, Line 123: Please remove the blank line.