Change in coreboot[master]: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Name of user not set (Code Review)

5 Feb 2020 5 Feb '20

6:41 p.m.

Name of user not set #1002789 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P

Enable the dGPU on the Lenovo T440P. It uses the same code (roughly) of the T430S. By default, it is set to be disabled however it can be enabled via the nvram option enable_dual_graphics.

Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Signed-off-by: Chris Morgan macromorgan@hotmail.com --- M src/mainboard/lenovo/t440p/cmos.default M src/mainboard/lenovo/t440p/cmos.layout M src/mainboard/lenovo/t440p/romstage.c 3 files changed, 23 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38723/1

diff --git a/src/mainboard/lenovo/t440p/cmos.default b/src/mainboard/lenovo/t440p/cmos.default index 0949e7b..bb8626d 100644 --- a/src/mainboard/lenovo/t440p/cmos.default +++ b/src/mainboard/lenovo/t440p/cmos.default @@ -10,4 +10,5 @@ sticky_fn=Disable trackpoint=Enable backlight=Keyboard +enable_dual_graphics=Disable usb_always_on=Disable diff --git a/src/mainboard/lenovo/t440p/cmos.layout b/src/mainboard/lenovo/t440p/cmos.layout index f65933a..802857e 100644 --- a/src/mainboard/lenovo/t440p/cmos.layout +++ b/src/mainboard/lenovo/t440p/cmos.layout @@ -69,7 +69,7 @@ 424 1 e 1 f1_to_f12_as_primary

# coreboot config options: northbridge -#435 2 e 12 hybrid_graphics_mode +435 1 e 1 enable_dual_graphics #437 3 r 0 unused 440 8 h 0 volume

diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index c8c630b..95d117e 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -22,6 +22,9 @@ #include <northbridge/intel/haswell/pei_data.h> #include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> +#include <option.h> +#include <ec/lenovo/pmh7/pmh7.h> +#include <device/pci_ops.h>

static const struct rcba_config_instruction rcba_config[] = { RCBA_SET_REG_16(D31IR, DIR_ROUTE(PIRQA, PIRQD, PIRQC, PIRQA)), @@ -100,4 +103,22 @@ };

romstage_common(&romstage_params); + + u8 enable_peg; + if (get_option(&enable_peg, "enable_dual_graphics") != CB_SUCCESS) + enable_peg = 0; + + bool power_en = pmh7_dgpu_power_state(); + + if (enable_peg != power_en) + pmh7_dgpu_power_enable(!power_en); + + if (!enable_peg) { + // Hide disabled dGPU device + u32 reg32 = pci_read_config32(PCI_DEV(0, 0, 0), DEVEN); + reg32 &= ~DEVEN_D1F0EN; + + pci_write_config32(PCI_DEV(0, 0, 0), DEVEN, reg32); + } + }

Attachments:

attachment.htm (text/html — 5.7 KB)

Show replies by date

Patrick Rudolph (Code Review)

5 Feb 5 Feb

6:57 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38723/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/cmos.layout:

https://review.coreboot.org/c/coreboot/+/38723/1/src/mainboard/lenovo/t440p/... PS1, Line 111: #12 0 Integrated Only Remove as well

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Wed, 05 Feb 2020 18:57:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

7:06 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38723

to look at the new patch set (#2).

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P

Enable the dGPU on the Lenovo T440P. It uses the same code (roughly) of the T430S. By default, it is set to be disabled however it can be enabled via the nvram option enable_dual_graphics.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38723/2

Name of user not set (Code Review)

7:11 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38723

to look at the new patch set (#3).

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38723/3

Name of user not set (Code Review)

7:12 p.m.

Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 3:

(1 comment)

Removed old cmos values for hybrid graphics (not present on T440p).

https://review.coreboot.org/c/coreboot/+/38723/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/cmos.layout:

https://review.coreboot.org/c/coreboot/+/38723/1/src/mainboard/lenovo/t440p/... PS1, Line 111: #12 0 Integrated Only

...

Remove as well

Fixed in subsequent commit.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 05 Feb 2020 19:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Iru Cai (vimacs) (Code Review)

6 Feb 6 Feb

3:04 a.m.

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 3:

What's the difference between dual graphics and hybrid graphics? T430 and T530 use DRIVERS_LENOVO_HYBRID_GRAPHICS, and T430s doesn't use this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-Comment-Date: Thu, 06 Feb 2020 03:04:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

6:51 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 3:

...

Patch Set 3:

What's the difference between dual graphics and hybrid graphics? T430 and T530 use DRIVERS_LENOVO_HYBRID_GRAPHICS, and T430s doesn't use this.

Hybrid graphics is a feature of dual graphics allowing to switch the display panel to either gpu at runtime. To safe costs and higher throughput graphics interconnects newer platforms doesn't have this mux any more. Starting with the t430s, it only has dual graphics/Optimus.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-Comment-Date: Thu, 06 Feb 2020 06:51:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

3:17 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38723

to look at the new patch set (#4).

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P

Enable the dGPU on the Lenovo T440P. It uses the same code (roughly) of the T430S. By default, it is set to be disabled however it can be enabled via the nvram option enable_dual_graphics. Removed hybrid graphics options too. Tested on a T440P with Ubuntu 18.04.3 (successful). Tested on same machine with Windows 10 1909 (blue screen at boot).

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38723/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 4 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

4:20 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mainboard/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 4:

(4 comments)

Does some documentation need to be updated?

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@7 PS4, Line 7: mainboard mb

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@12 PS4, Line 12: Removed hybrid graphics options too. Why?

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@9 PS4, Line 9: Enable the dGPU on the Lenovo T440P. It uses the same code : (roughly) of the T430S. By default, it is set to be : disabled however it can be enabled via the nvram option : enable_dual_graphics. Removed hybrid graphics options too. : Tested on a T440P with Ubuntu 18.04.3 (successful). Tested : on same machine with Windows 10 1909 (blue screen at boot). Please reflow for 75 characters.

https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/romstage.c:

https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... PS4, Line 123: Please remove the blank line.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 4 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Feb 2020 16:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

6:24 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38723

to look at the new patch set (#5).

Change subject: mb/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Enable the dGPU on the Lenovo T440P. It uses the same code (roughly) of the T430S. By default, it is set to be disabled however it can be enabled via the nvram option enable_dual_graphics. Removed hybrid graphics options too as they are not valid for the T440p. Tested on a T440P with Ubuntu 18.04.4 with Kernel 5.3.0-29 (successful). Tested on same machine with Windows 10 1909 (machine check exception bluescreen).

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/38723/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

6:26 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mb/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 5:

(4 comments)

Comments resolved.

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@7 PS4, Line 7: mainboard

...

mb

Ack

https://review.coreboot.org/c/coreboot/+/38723/4//COMMIT_MSG@12 PS4, Line 12: Removed hybrid graphics options too.

...

Why?

They are not valid for the T440p which has a muxless dGPU.

...

Please reflow for 75 characters.

Ack

https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/romstage.c:

https://review.coreboot.org/c/coreboot/+/38723/4/src/mainboard/lenovo/t440p/... PS4, Line 123:

...

Please remove the blank line.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Feb 2020 18:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

7 Feb 7 Feb

5:18 a.m.

New subject: Change in coreboot[master]: mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mb/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Feb 2020 05:18:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Feb 9 Feb

7:24 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38723 )

Change subject: mb/lenovo/t440p: Enable dGPU on Lenovo T440P ......................................................................

mb/lenovo/t440p: Enable dGPU on Lenovo T440P

Enable the dGPU on the Lenovo T440P. It uses the same code (roughly) of the T430S. By default, it is set to be disabled however it can be enabled via the nvram option enable_dual_graphics. Removed hybrid graphics options too as they are not valid for the T440p. Tested on a T440P with Ubuntu 18.04.4 with Kernel 5.3.0-29 (successful). Tested on same machine with Windows 10 1909 (machine check exception bluescreen).

Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Signed-off-by: Chris Morgan macromorgan@hotmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38723 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/t440p/cmos.default M src/mainboard/lenovo/t440p/cmos.layout M src/mainboard/lenovo/t440p/romstage.c 3 files changed, 22 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t440p/cmos.default b/src/mainboard/lenovo/t440p/cmos.default index 0949e7b..bb8626d 100644 --- a/src/mainboard/lenovo/t440p/cmos.default +++ b/src/mainboard/lenovo/t440p/cmos.default @@ -10,4 +10,5 @@ sticky_fn=Disable trackpoint=Enable backlight=Keyboard +enable_dual_graphics=Disable usb_always_on=Disable diff --git a/src/mainboard/lenovo/t440p/cmos.layout b/src/mainboard/lenovo/t440p/cmos.layout index f65933a..9c09104 100644 --- a/src/mainboard/lenovo/t440p/cmos.layout +++ b/src/mainboard/lenovo/t440p/cmos.layout @@ -69,7 +69,7 @@ 424 1 e 1 f1_to_f12_as_primary

# coreboot config options: northbridge -#435 2 e 12 hybrid_graphics_mode +435 1 e 1 enable_dual_graphics #437 3 r 0 unused 440 8 h 0 volume

@@ -108,9 +108,6 @@ 10 1 Keyboard #10 2 Thinklight only 10 3 None -#12 0 Integrated Only -#12 1 Discrete Only -#12 2 Dual Graphics 13 0 Disable 13 1 AC and battery 13 2 AC only diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index c8c630b..283a52b 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -22,6 +22,9 @@ #include <northbridge/intel/haswell/pei_data.h> #include <southbridge/intel/common/gpio.h> #include <southbridge/intel/lynxpoint/pch.h> +#include <option.h> +#include <ec/lenovo/pmh7/pmh7.h> +#include <device/pci_ops.h>

static const struct rcba_config_instruction rcba_config[] = { RCBA_SET_REG_16(D31IR, DIR_ROUTE(PIRQA, PIRQD, PIRQC, PIRQA)), @@ -100,4 +103,21 @@ };

-- To view, visit https://review.coreboot.org/c/coreboot/+/38723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf8c2c0d1ae34bda8736448d3e350396e3cf7a93 Gerrit-Change-Number: 38723 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1002789 Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Name of user not set #1002789 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1557

days inactive

1561

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Iru Cai (vimacs) (Code Review)
Name of user not set (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)