Change in coreboot[master]: mb/google/dedede: Log mainboard SMI events to elog

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard SMI events to elog
......................................................................

mb/google/dedede: Log mainboard SMI events to elog

BUG=b:148410914
TEST=Build the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: I7dffa5c021787dca75786ead42164bd29ba56828
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/38724/1

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c
index 2c2230f..deb2223 100644
--- a/src/mainboard/google/dedede/smihandler.c
+++ b/src/mainboard/google/dedede/smihandler.c
@@ -8,7 +8,9 @@

#include <baseboard/variants.h>
 #include <cpu/x86/smm.h>
+#include <ec/google/chromeec/ec.h>
 #include <ec/google/chromeec/smm.h>
+#include <elog.h>
 #include <intelblocks/smihandler.h>
 #include <variant/ec.h>

@@ -35,3 +37,9 @@
    			MAINBOARD_EC_SMI_EVENTS);
    return 0;
 }
+
+void elog_gsmi_cb_mainboard_log_wake_source(void)
+{
+	google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
+					MAINBOARD_EC_S0IX_WAKE_EVENTS);
+}

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard SMI events to elog
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38724/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38724/1//COMMIT_MSG@7 
PS1, Line 7: SMI
It is not necessarily only SMI events.

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Karthik Ramasubramanian (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38724

to look at the new patch set (#2).

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

mb/google/dedede: Log mainboard events to elog

BUG=b:148410914
TEST=Build the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: I7dffa5c021787dca75786ead42164bd29ba56828
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/38724/2

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38724/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38724/1//COMMIT_MSG@7 
PS1, Line 7: SMI
> It is not necessarily only SMI events.

Done

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
PS2, Line 44: 					MAINBOARD_EC_S0IX_WAKE_EVENTS);
Does this fit into 96 characters?

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Karthik Ramasubramanian (Code Review)]

Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38724

to look at the new patch set (#3).

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

mb/google/dedede: Log mainboard events to elog

BUG=b:148410914
TEST=Build the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: I7dffa5c021787dca75786ead42164bd29ba56828
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/38724/3

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
PS2, Line 44: 					MAINBOARD_EC_S0IX_WAKE_EVENTS);
> Does this fit into 96 characters?

I have put the entire statement in a line < 96 characters. Hope checkpatch is updated to handle 96 characters limit. /util/lint/checkpatch.pl complains about greater than 80 characters.

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38724/2/src/mainboard/google/dedede... 
PS2, Line 44: 					MAINBOARD_EC_S0IX_WAKE_EVENTS);
> I have put the entire statement in a line < 96 characters. […]

Done

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Log mainboard events to elog

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38724 )

Change subject: mb/google/dedede: Log mainboard events to elog
......................................................................

mb/google/dedede: Log mainboard events to elog

BUG=b:148410914
TEST=Build the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: I7dffa5c021787dca75786ead42164bd29ba56828
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38724
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Justin TerAvest 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/dedede/smihandler.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c
index 2c2230f..4e3c830 100644
--- a/src/mainboard/google/dedede/smihandler.c
+++ b/src/mainboard/google/dedede/smihandler.c
@@ -8,7 +8,9 @@

#include <baseboard/variants.h>
 #include <cpu/x86/smm.h>
+#include <ec/google/chromeec/ec.h>
 #include <ec/google/chromeec/smm.h>
+#include <elog.h>
 #include <intelblocks/smihandler.h>
 #include <variant/ec.h>

@@ -35,3 +37,8 @@
    			MAINBOARD_EC_SMI_EVENTS);
    return 0;
 }
+
+void elog_gsmi_cb_mainboard_log_wake_source(void)
+{
+	google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS);
+}