Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 34:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33387/26/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/26/Documentation/mainboard/em... PS26, Line 19: reserved for a FIT image
Thank you!
Done
https://review.coreboot.org/c/coreboot/+/33387/22/src/lib/fit_payload.c File src/lib/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/33387/22/src/lib/fit_payload.c@249 PS22, Line 249: if (config->ramdisk && initrd.size > 0) {
OK. I reverted this change in the CL and created new CL (https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... PS26, Line 8: chip mainboard/emulation/qemu-aarch64
I removed the mainboard part. It doesn't affect any output messages at all so probably you're right. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/26/src/mainboard/emulation/qe... PS26, Line 9: chip drivers/generic/generic # I2C0 controller
Okay, fair enough, this could probably be fixed in sconfig but let's leave this here for now.
Done
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... PS21, Line 26: BOOTBLOCK(0x60010000, 64K)
OK. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/18/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/mmio.c:
https://review.coreboot.org/c/coreboot/+/33387/18/src/mainboard/emulation/qe... PS18, Line 14: // TODO: Return VIRT_SECURE_UART_BASE when QEMU works on a secure mode.
Yes, unless you actually know something that needs to be done here in the future, you should probabl […]
Done