mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/31448/10/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/#/c/31448/10/src/device/pci_device.c@830 PS10, Line 830: Integrated
That is poor reasoning. […]
Should I mention a PCI device class instead of Integrated / Discrete? Something like
if (pci_class == PCI_CLASS_DISPLAY_VGA) printk(BIOS_DEBUG, "PCI_CLASS_DISPLAY_VGA ROM probe failed\n"); else printk(BIOS_DEBUG, "PCI_CLASS_DISPLAY_OTHER VGA ROM probe failed\n");
"else" message is valid since we could reach this code only when pci_class is either PCI_CLASS_DISPLAY_VGA or PCI_CLASS_DISPLAY_OTHER with CONFIG(MULTIPLE_VGA_ADAPTERS) enabled.
https://review.coreboot.org/#/c/31448/10/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/10/src/device/pci_rom.c@230 PS10, Line 230: if (!CONFIG(MULTIPLE_VGA_ADAPTERS)) {
No board Kconfigs in here please. […]
Thank you, will try to change it without using a Kconfig