2 comments:
Patch Set #10, Line 830: Integrated
That is poor reasoning. […]
Should I mention a PCI device class instead of Integrated / Discrete? Something like
if (pci_class == PCI_CLASS_DISPLAY_VGA)
printk(BIOS_DEBUG, "PCI_CLASS_DISPLAY_VGA ROM probe failed\n");
else
printk(BIOS_DEBUG, "PCI_CLASS_DISPLAY_OTHER VGA ROM probe failed\n");
"else" message is valid since we could reach this code only when pci_class is either PCI_CLASS_DISPLAY_VGA or PCI_CLASS_DISPLAY_OTHER with CONFIG(MULTIPLE_VGA_ADAPTERS) enabled.
Patch Set #10, Line 230: if (!CONFIG(MULTIPLE_VGA_ADAPTERS)) {
No board Kconfigs in here please. […]
Thank you, will try to change it without using a Kconfig
To view, visit change 31448. To unsubscribe, or for help writing mail filters, visit settings.