Attention is currently required from: Paul Menzel, Angel Pons, xin hua wang, Felix Held.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support
......................................................................
Patch Set 43:
(2 comments)
Patchset:
PS43:
Awesome work.
Thank you!
PS43:
https://review.coreboot. […]
Well then maybe that util unreliable or something, I don't know. As a guy who made this port, I'm telling you, the port on the right side works :) and it's documented here https://review.coreboot.org/c/coreboot/+/32673/43/Documentation/mainboard/ap...
I also saw your comment in the 8,1 patch; I can't tell which port works there right now but I'm pretty sure that some worked.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32673
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df
Gerrit-Change-Number: 32673
Gerrit-PatchSet: 43
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 20 Dec 2021 20:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: xin hua wang
xinhuawang0101@gmail.com
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Gerrit-MessageType: comment