Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 6:
(8 comments)
Please don't use camel case for filenames, variables, function names and structs. applies to all files and all commits.
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@369 PS6, Line 369: // whitespace at begging of line applies to all files, all commits
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@442 PS6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
How does one deal with statements that really cannot be split
try to use functions if the indentation is too much
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@791 PS6, Line 791: uint32_t uintptr_t
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformRe... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformRe... PS6, Line 38: void FixupPciexResource(void); looks like those can be made static. in that case there's no need to define a function prototype
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformRe... PS6, Line 186: //RscPcieMmio.Base = PcdGet64 (PcdPciExpressBaseAddress); CONFIG_MMCONF_BASE_ADDRESS on some platforms: CONFIG_SA_PCIEX_LENGTH
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformSm... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformSm... PS6, Line 53: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u\n", %p
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformSm... PS6, Line 54: (uint32_t) MsegBase, StmImageSize); remove case
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/StmPlatformSm... PS6, Line 87: void ReadGdtr(struct descriptor *gdtr) static