Please don't use camel case for filenames, variables, function names and structs.
applies to all files and all commits.
8 comments:
File src/security/intel/stm/SmmStm.c:
whitespace at begging of line
applies to all files, all commits
Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >
How does one deal with statements that really cannot be split
try to use functions if the indentation is too much
Patch Set #6, Line 791: uint32_t
uintptr_t
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #6, Line 38: void FixupPciexResource(void);
looks like those can be made static. in that case there's no need to define a function prototype
Patch Set #6, Line 186: //RscPcieMmio.Base = PcdGet64 (PcdPciExpressBaseAddress);
CONFIG_MMCONF_BASE_ADDRESS
on some platforms: CONFIG_SA_PCIEX_LENGTH
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #6, Line 53: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u\n",
%p
Patch Set #6, Line 54: (uint32_t) MsegBase, StmImageSize);
remove case
Patch Set #6, Line 87: void ReadGdtr(struct descriptor *gdtr)
static
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.