Attention is currently required from: Angel Pons, Iru Cai (vimacs). Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41473 )
Change subject: inteltool: Support dumping IOBP register values ......................................................................
Patch Set 17: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/41473/comment/d2e97f59_07f8e00a PS3, Line 13: SATA_IOBP_SP*G3IR : (does LynxPoint really use them?)
They don't seem to exist.
Ack
File util/inteltool/iobp.c:
https://review.coreboot.org/c/coreboot/+/41473/comment/612986d3_5450e537 PS3, Line 8: rcba
`rcba`. […]
Done
File util/inteltool/iobp.c:
https://review.coreboot.org/c/coreboot/+/41473/comment/4e490d2b_e8ec860c PS17, Line 8: , nit: space after the comma (same for RCBA32)
https://review.coreboot.org/c/coreboot/+/41473/comment/f0f79405_0b5ba3d2 PS17, Line 76: char * should be `const char *`, which means "pointer to `const char`"
https://review.coreboot.org/c/coreboot/+/41473/comment/d28db478_9b3472a1 PS17, Line 74: typedef struct { : u32 addr; : char *name; : } iobp_register_t; Is a typedef really needed?
struct iobp_register { u32 addr; const char *name; };
https://review.coreboot.org/c/coreboot/+/41473/comment/80f3df99_cea96487 PS17, Line 88: {0xea002558, "SECRR58P0"}, I'd like to avoid repeating the registers for each port. Also, this doesn't account for HSIO lane muxing. I'll look into it and make follow-up patches.
Nothing to do in this change.