Attention is currently required from: Angel Pons, Iru Cai (vimacs).
Patch set 17:Code-Review +1
6 comments:
Commit Message:
SATA_IOBP_SP*G3IR
(does LynxPoint really use them?)
They don't seem to exist.
Ack
File util/inteltool/iobp.c:
`rcba`. […]
Done
File util/inteltool/iobp.c:
nit: space after the comma (same for RCBA32)
Patch Set #17, Line 76: char *
should be `const char *`, which means "pointer to `const char`"
typedef struct {
u32 addr;
char *name;
} iobp_register_t;
Is a typedef really needed?
struct iobp_register {
u32 addr;
const char *name;
};
Patch Set #17, Line 88: {0xea002558, "SECRR58P0"},
I'd like to avoid repeating the registers for each port. Also, this doesn't account for HSIO lane muxing. I'll look into it and make follow-up patches.
Nothing to do in this change.
To view, visit change 41473. To unsubscribe, or for help writing mail filters, visit settings.