HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/inagua/ir... File src/mainboard/amd/inagua/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/inagua/ir... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/parmer/ir... File src/mainboard/amd/parmer/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/parmer/ir... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/persimmon... File src/mainboard/amd/persimmon/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/persimmon... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/south_sta... File src/mainboard/amd/south_station/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/south_sta... PS2, Line 65: pirq->rtr_devfn = PCI_DEVFN(0x14, 4); needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/thatcher/... File src/mainboard/amd/thatcher/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/thatcher/... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/union_sta... File src/mainboard/amd/union_station/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/union_sta... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/biostar/a68n_... File src/mainboard/biostar/a68n_5200/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/biostar/a68n_... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/elmex/pcm2054... File src/mainboard/elmex/pcm205400/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/elmex/pcm2054... PS2, Line 67: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/gizmosphere/g... File src/mainboard/gizmosphere/gizmo2/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/gizmosphere/g... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/front... File src/mainboard/lippert/frontrunner-af/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/front... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/touca... File src/mainboard/lippert/toucan-af/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/touca... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>