Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 11:
(7 comments)
This change is ready for review.
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... File src/mainboard/emulation/qemu-aarch64/Kconfig:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 6: ## This software is licensed under the terms of the GNU General Public
Use the SPDX identifier instead of adding the whole licence: […]
OK. I updated all files to use the SPDX identifier.
According to the SPDX site (https://spdx.org/licenses/), GPL 2.0 supports - GPL-2.0-only - GPL-2.0-or-later
I chose GPL-2.0-or-later.
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 20: # qemu-system-aarch64 -M virt -m 1024M -cpu cortex-a53 -nographic -bios build/coreboot.rom
Can you move this to Kconfig.name as a help entry, so it shows up in make menuconfig.
Yes. I moved it to a help section in Kconfig.name.
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 56: ARM
QEMU?
Ack
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... File src/mainboard/emulation/qemu-aarch64/bootblock_custom.S:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 36: works
Does it work with -machine secure=on to emulate EL3?
Yes, it does. I will remove this function.
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... File src/mainboard/emulation/qemu-aarch64/cbmem.c:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 28: _eprogram
Keep in mind that it need to return the same address in every stage, but _eprogram changes in every […]
OK. Thank you. Is the rule to return the same address in every stage specify only for ARMv8?
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... File src/mainboard/emulation/qemu-aarch64/mainboard.h:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 1: /*
I would do SPDX headers for all the files you are adding.
Ack
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/#/c/33387/6/src/mainboard/emulation/qemu-aarch64... PS6, Line 47: VIRT_FLASH_START
Need to be placed in RAM in order for heap to work. […]
Can I decide SRAM addresses by myself? Because the virt machine doesn't seem to have SRAM address according to the implementation in QEMU (https://github.com/qemu/qemu/blob/master/hw/arm/virt.c).
Or is it ok to make BOOTBLOCK place inside DRAM?