Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33621/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33621/4//COMMIT_MSG@12
PS4, Line 12: b:none
Nit - You don't need the b: if there's no bug.
https://review.coreboot.org/c/coreboot/+/33621/4/src/soc/amd/stoneyridge/Mak...
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33621/4/src/soc/amd/stoneyridge/Mak...
PS4, Line 250:
Remove this blank line. Makefiles don't allow blank lines in the a rule. GNU make might overlook it, but it shouldn't be here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f960b8f012c5a1cfd398611d6a51838493da27
Gerrit-Change-Number: 33621
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Jul 2019 21:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment