Attention is currently required from: Felix Singer, Nico Huber, Benjamin Doron, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 172:
(4 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/c52ad251_7fbc5103 PS172, Line 32: /* SIO init from PeiOemSioInit not necessary - only conditionally executed; not executed on system */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/e9655621_f85c238f PS172, Line 47: /* "MLID" in LGMR-based memory map is equivalent to "ELID" in EC-based memory map line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/ec.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/6b7d083e_e738117d PS172, Line 65: stopwatch_init_usecs_expire(&sw, 1000); // Vendor firmware gives 200 iterations of `Stall(5)` line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/cb8e752e_72189ffb PS172, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)