Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35903 )
Change subject: mb/google/hatch: Set FPS as wake source ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35903/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/35903/1/src/mainboard/google/hatch/... PS1, Line 62: LEVEL
It was a level triggered interrupt before, so this shouldn't change.
OK
https://review.coreboot.org/c/coreboot/+/35903/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35903/1/src/mainboard/google/hatch/... PS1, Line 174: ACPI_IRQ_WAKE_LEVEL_LOW
It has been a level-triggered interrupt, why would it need to change to edge?
Wasn't sure if we needed to change to edge-triggered since it is becoming a wake-up source.