David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31196 )
Change subject: cpu/intel: Use macro instead of numbers ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31196/1/src/cpu/intel/fsp_model_406dx/model_... File src/cpu/intel/fsp_model_406dx/model_406dx_init.c:
https://review.coreboot.org/#/c/31196/1/src/cpu/intel/fsp_model_406dx/model_... PS1, Line 51: TM2
TM2 is at (1 << 13) , right ?
Yes, and BIT3 is Automatic Thermal Control Circuit Enable (R/W) 1 = Setting this bit enables the thermal control circuit (TCC) portion of the Intel Thermal Monitor feature. This allows the processor to automatically reduce power consumption in response to TCC activation. 0 = Disabled (default). Note: In some products clearing this bit might be ignored in critical thermal conditions, and TM1, TM2 and adaptive thermal throttling will still be activated.
I suppose the comment could be updated