Patch set 1:Code-Review +1

View Change

1 comment:

• File src/cpu/intel/fsp_model_406dx/model_406dx_init.c:

  • Patch Set #1, Line 51: TM2

    TM2 is at (1 << 13) , right ?

    Yes, and BIT3 is Automatic Thermal Control Circuit Enable (R/W)
    1 = Setting this bit enables the thermal
    control circuit (TCC) portion of the
    Intel Thermal Monitor feature. This
    allows the processor to automatically
    reduce power consumption in
    response to TCC activation.
    0 = Disabled (default).
    Note: In some products clearing this bit
    might be ignored in critical thermal
    conditions, and TM1, TM2 and adaptive
    thermal throttling will still be activated.

    I suppose the comment could be updated

To view, visit change 31196. To unsubscribe, or for help writing mail filters, visit settings.