Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30844 )
Change subject: string.h: allow to compile strdup in romstage ......................................................................
Patch Set 6:
- don't define ASSERT() in assert.h (e.g. rename it to _ASSERT()). existing calls should call the standard assert()
I think that wouldn't be a bad change (we should standardize on assert() and have nothing else), but I think other files in coreboot shouldn't make up their own ASSERT() either.
Note that that's only half the issues, there's also https://qa.coreboot.org/job/coreboot-gerrit/87667/testReport/junit/board/chr... which I'm not quite sure about. It seems to be some weird include path problem with vboot (and maybe a hint that we shouldn't implement all our string functions as static inlines in headers anyway... why are we doing that?).