1. don't define ASSERT() in assert.h (e.g. rename it to _ASSERT()). existing calls should call the standard assert()
I think that wouldn't be a bad change (we should standardize on assert() and have nothing else), but I think other files in coreboot shouldn't make up their own ASSERT() either.
Note that that's only half the issues, there's also https://qa.coreboot.org/job/coreboot-gerrit/87667/testReport/junit/board/chromeos/GOOGLE_GRU/ which I'm not quite sure about. It seems to be some weird include path problem with vboot (and maybe a hint that we shouldn't implement all our string functions as static inlines in headers anyway... why are we doing that?).
To view, visit change 30844. To unsubscribe, or for help writing mail filters, visit settings.