[coreboot-gerrit] Change in ...coreboot[master]: soc/amd: Update ACPI code

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 )

Change subject: soc/amd: Update ACPI code
......................................................................

Patch Set 2:

(1 comment)

I think you should separate your OS stuff into a separate stack.  Keep the additional cores change for the merlinfalcon work.

https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl 
File src/soc/amd/common/acpi/lpc.asl:

https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl@35 
PS2, Line 35: PNP0C02 apparently fails with WIN7 and WIN10. Until better
            : 	 * understood,
I'm not sure why "apparently" here.  Either it fails or it doesn't.  Also, I wouldn't call it PNP0C02 in the comment.  That's simply describing LDRC as a generic motherboard resource.