Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 ) Change subject: soc/amd: Update ACPI code ...................................................................... Patch Set 2: (1 comment) I think you should separate your OS stuff into a separate stack. Keep the additional cores change for the merlinfalcon work. https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl File src/soc/amd/common/acpi/lpc.asl: https://review.coreboot.org/#/c/33620/2/src/soc/amd/common/acpi/lpc.asl@35 PS2, Line 35: PNP0C02 apparently fails with WIN7 and WIN10. Until better : * understood, I'm not sure why "apparently" here. Either it fails or it doesn't. Also, I wouldn't call it PNP0C02 in the comment. That's simply describing LDRC as a generic motherboard resource. -- To view, visit https://review.coreboot.org/c/coreboot/+/33620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3615a4460dd4e0c95e890a38210263dd8ea6887 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: Charles Marslett <charles.marslett@silverbackltd.com> Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2019 14:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment