[coreboot-gerrit] Change in coreboot[master]: cbfs: Simplify load/map API names, remove type arguments

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39304 )

Change subject: cbfs: Simplify load/map API names, remove type arguments
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39304/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39304/4//COMMIT_MSG@24 
PS4, Line 24: known
> Sorry, I'm not sure what you're saying... […]

I'm merely trying to ensure we don't allow for lazy programming. That and those knowns are not always true. I wasn't asking you to fix up all the other code, but...

cbfs_boot_map_with_leak -> cbfs_map

Now the code looks like it's ok to never pair an unmap. The ugly naming forces one to think about the behavior of the code being written or copied.

Anyway, it seems you aren't that concerned so we can let it be.

https://review.coreboot.org/c/coreboot/+/39304/4/src/security/vboot/ec_sync.... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/39304/4/src/security/vboot/ec_sync.... 
PS4, Line 397:
> We're returning the pointer to the caller, its contents must remain valid. […]

got it. ick.