2 comments:
Patch Set #4, Line 24: known
Sorry, I'm not sure what you're saying... […]
I'm merely trying to ensure we don't allow for lazy programming. That and those knowns are not always true. I wasn't asking you to fix up all the other code, but...
cbfs_boot_map_with_leak -> cbfs_map
Now the code looks like it's ok to never pair an unmap. The ugly naming forces one to think about the behavior of the code being written or copied.
Anyway, it seems you aren't that concerned so we can let it be.
File src/security/vboot/ec_sync.c:
We're returning the pointer to the caller, its contents must remain valid. […]
got it. ick.
To view, visit change 39304. To unsubscribe, or for help writing mail filters, visit settings.