Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43663 )
Change subject: mb/google/zork/vilboz: enable LTE function ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 5: #include <boardid.h> Is this required?
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 6: #include <gpio.h> Is this required?
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 14: extra blank line not required.
https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 17: extra tab not required here and in the next line.