Change in coreboot[master]: mb/google/zork/vilboz: enable LTE function
Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43663 ) Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... mb/google/zork/vilboz: enable LTE function BUG=b:161736991 TEST=flash the BIOS and insure LTE function work properly Signed-off-by: Peichao.Wang <peichao.wang@bitland.corp-partner.google.com> Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e --- M src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/gpio.c 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/43663/1 diff --git a/src/mainboard/google/zork/variants/vilboz/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/Makefile.inc index dc1e411..51d19fe 100644 --- a/src/mainboard/google/zork/variants/vilboz/Makefile.inc +++ b/src/mainboard/google/zork/variants/vilboz/Makefile.inc @@ -2,4 +2,5 @@ subdirs-y += ./spd +ramstage-y += gpio.c ramstage-y += variant.c diff --git a/src/mainboard/google/zork/variants/vilboz/gpio.c b/src/mainboard/google/zork/variants/vilboz/gpio.c new file mode 100644 index 0000000..4d292c2 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/gpio.c @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> +#include <baseboard/variants.h> +#include <boardid.h> +#include <gpio.h> +#include <soc/gpio.h> + +static const struct soc_amd_gpio lte_gpio_set_stage_ram[] = { + /* LTE POWER ENABLE */ + PAD_GPO(GPIO_32, HIGH), +}; + + +const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) +{ + *size = ARRAY_SIZE(lte_gpio_set_stage_ram); + return lte_gpio_set_stage_ram; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/43663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-MessageType: newchange
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43663 ) Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c: https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 5: #include <boardid.h> Is this required? https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 6: #include <gpio.h> Is this required? https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 14: extra blank line not required. https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 17: extra tab not required here and in the next line. -- To view, visit https://review.coreboot.org/c/coreboot/+/43663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-Comment-Date: Tue, 21 Jul 2020 03:38:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/43663 to look at the new patch set (#2). Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... mb/google/zork/vilboz: enable LTE function BUG=b:161736991 TEST=flash the BIOS and insure LTE function work properly Signed-off-by: Peichao.Wang <peichao.wang@bitland.corp-partner.google.com> Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e --- M src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/gpio.c 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/43663/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/43663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: newpatchset
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43663 ) Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c: https://review.coreboot.org/c/coreboot/+/43663/1/src/mainboard/google/zork/v... PS1, Line 5: #include <boardid.h>
Is this required? Dear Furquan, I think may need to keep this, since some SKUs have LTE module, we need a logistic to control it. I need confirm with our PM. In addition, I think we need to add LTE module information into boxster. Right? Many thanks!
-- To view, visit https://review.coreboot.org/c/coreboot/+/43663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-Comment-Date: Tue, 21 Jul 2020 05:05:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43663 ) Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/c/coreboot/+/43663/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/43663/2//COMMIT_MSG@2 PS2, Line 2: peichao.wang Peichao Wang https://review.coreboot.org/c/coreboot/+/43663/2//COMMIT_MSG@10 PS2, Line 10: insure LTE function work properly How? https://review.coreboot.org/c/coreboot/+/43663/2//COMMIT_MSG@12 PS2, Line 12: Peichao.Wang Peichao Wang -- To view, visit https://review.coreboot.org/c/coreboot/+/43663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz@google.com> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Kangheui Won <khwon@google.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Sam McNally <sammc@google.com> Gerrit-Comment-Date: Mon, 19 Oct 2020 15:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43663?usp=email ) Change subject: mb/google/zork/vilboz: enable LTE function ...................................................................... Abandoned This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author. -- To view, visit https://review.coreboot.org/c/coreboot/+/43663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I130bd76aad0a4b8f3a82090d97f140a0a7ed958e Gerrit-Change-Number: 43663 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz@google.com> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh@gmail.com> Gerrit-CC: Kangheui Won <khwon@google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Sam McNally <sammc@google.com> Gerrit-MessageType: abandon
participants (4)
-
Furquan Shaikh (Code Review) -
Martin L Roth (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)