Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45405 )
Change subject: console: Override uart base address
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
This is more consistent with the other console overrides.
https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io...
File src/drivers/uart/uart8250io.c:
https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io...
PS2, Line 78: static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
Marc, For DeltaLake, we are in the process of polishing the firmware image for it to be used by othe […]
I was trying to understand how it changes to get to the best support. It does seem like some kind of platform override would work here, but I'm not sure that weak calls vs platforms or a build time config option like the OVERRIDE_BAUD would be more correct. It seems that there are more weak functions in coreboot now, but that has its own issues.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
Gerrit-Change-Number: 45405
Gerrit-PatchSet: 3
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 16:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-MessageType: comment