This is more consistent with the other console overrides.

Patch set 3:Code-Review +1

View Change

1 comment:

• File src/drivers/uart/uart8250io.c:

  • Patch Set #2, Line 78: static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };

    Marc, For DeltaLake, we are in the process of polishing the firmware image for it to be used by othe […]

    I was trying to understand how it changes to get to the best support. It does seem like some kind of platform override would work here, but I'm not sure that weak calls vs platforms or a build time config option like the OVERRIDE_BAUD would be more correct. It seems that there are more weak functions in coreboot now, but that has its own issues.

To view, visit change 45405. To unsubscribe, or for help writing mail filters, visit settings.