Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47432 )
Change subject: mb/google/dedede: Add the CSE RW firmware version ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/47432/5/src/mainboard/google/dedede... PS5, Line 108: SOC_INTEL_CSE_RW_VERSION I think it would be better to set this in config.${BOARD} in chromiumos-overlay? That will allow us to add Cq-Depends directly between the uprev of CSE binary in private overlays and the update of this Kconfig. What do you think?
Also, as we are making this change to add RW metadata, I think it would be best to turn off the RW update feature for now. In the previous CL, I made a suggestion about adding a Kconfig for enabling RW update feature. If that is done, then by default we can keep the Kconfig disabled and only enable it after this patch series is pushed. Thoughts?