Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31131 )
Change subject: soc/intel/apollolake: Sync fsp upd structure update ......................................................................
Patch Set 5:
Just food for thought (I guess Intel probably has to revise their release processes for a while longer, given that the ability to publish trouble-free FSP releases on github is still rather new):
It may be best to see such updates go to https://github.com/IntelFsp/FSP. We automatically mirror that repo on coreboot.org, ensuring availability. With that, you only need to update the 3rdparty/fsp submodule pointer and use the files there instead of keeping copies of FSP headers in the coreboot repo synchronized.
By standardizing on such an approach every FSP user benefits from updates and everybody can be sure that their FSP binary (that they get from IntelFSP/FSP) matches the headers (since they get them from the same place).