Just food for thought (I guess Intel probably has to revise their release processes for a while longer, given that the ability to publish trouble-free FSP releases on github is still rather new):

It may be best to see such updates go to https://github.com/IntelFsp/FSP. We automatically mirror that repo on coreboot.org, ensuring availability. With that, you only need to update the 3rdparty/fsp submodule pointer and use the files there instead of keeping copies of FSP headers in the coreboot repo synchronized.

By standardizing on such an approach every FSP user benefits from updates and everybody can be sure that their FSP binary (that they get from IntelFSP/FSP) matches the headers (since they get them from the same place).

View Change

To view, visit change 31131. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d17dfbe58bdc5222378459723da8e9ac0573510
Gerrit-Change-Number: 31131
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com>
Gerrit-Reviewer: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shamile Khan <shamile.khan@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 13:34:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment