Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )
Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47292/2//COMMIT_MSG@9 PS2, Line 9: Per elan request, change to level trigger to fix touchscreen function lost
Can you please add the following detail to the commit message: […]
Done, thanks
https://review.coreboot.org/c/coreboot/+/47292/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47292/3//COMMIT_MSG@15 PS3, Line 15: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d... : hid-over-i2c-protocol-spec-v1-0.docx
Nit: I think we can have greater than 72 characters for URLs. Otherwise the link looks broken.
Done, thanks
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede... PS2, Line 202: ACPI_IRQ_LEVEL_LOW
Thanks for the reference Wisley! Can you please update the commit message as per the comment provide […]
Done, thanks